linux-hardening - Re: [PATCH] ethernet: sis900: use sizeof(*pointer) instead of sizeof(type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240612175516.02725d94@kernel.org>
Date: Wed, 12 Jun 2024 17:55:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Erick Archer <erick.archer@...look.com>
Cc: Daniele Venzano <venza@...wnhat.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Kees Cook <keescook@...omium.org>, "Gustavo A. R.
 Silva" <gustavoars@...nel.org>, Justin Stitt <justinstitt@...gle.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ethernet: sis900: use sizeof(*pointer) instead of
 sizeof(type)

On Sat,  8 Jun 2024 12:20:33 +0200 Erick Archer wrote:
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter).
> 
> At the same time remove some unnecessary initializations and
> refactor a bit to make the code clearer.
> 
> This patch has no effect on runtime behavior.

This is an ancient driver, unfortunately we prefer not to apply minor
code cleanups of this nature unless they are a part of other development
work. We'd be constantly tweaking the 200+ drivers we have, most of
which get zero use.
-- 
pw-bot: reject