linux-hardening - Re: [PATCH AUTOSEL 6.1 07/29] efi: pstore: Return proper errors on UEFI failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53728bf9-8395-831c-f6bc-be79a379fe8a@igalia.com>
Date: Mon, 17 Jun 2024 12:16:19 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Sasha Levin <sashal@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
 stable@...r.kernel.org
Cc: Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 07/29] efi: pstore: Return proper errors on
 UEFI failures

On 17/06/2024 10:24, Sasha Levin wrote:
> From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
> 
> [ Upstream commit 7c23b186ab892088f76a3ad9dbff1685ffe2e832 ]
> 
> Right now efi-pstore either returns 0 (success) or -EIO; but we
> do have a function to convert UEFI errors in different standard
> error codes, helping to narrow down potential issues more accurately.
> 
> So, let's use this helper here.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Following Ard's comment for the other releases, let's not backport this one.

Thanks,

Guilherme