linux-hardening - Re: [PATCH] string: kunit: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd6c0b05-fe43-4405-bce1-ad765ec6c4d3@quicinc.com>
Date: Thu, 20 Jun 2024 09:45:01 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook
	<keescook@...omium.org>, Andy Shevchenko <andy@...nel.org>
CC: <linux-hardening@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros

On 5/31/2024 4:07 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_helpers_kunit.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  lib/string_helpers_kunit.c | 1 +
>  lib/string_kunit.c         | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/lib/string_helpers_kunit.c b/lib/string_helpers_kunit.c
> index f88e39fd68d6..c853046183d2 100644
> --- a/lib/string_helpers_kunit.c
> +++ b/lib/string_helpers_kunit.c
> @@ -625,4 +625,5 @@ static struct kunit_suite string_helpers_test_suite = {
>  
>  kunit_test_suites(&string_helpers_test_suite);
>  
> +MODULE_DESCRIPTION("Test cases for string helpers module");
>  MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/lib/string_kunit.c b/lib/string_kunit.c
> index 2a812decf14b..c919e3293da6 100644
> --- a/lib/string_kunit.c
> +++ b/lib/string_kunit.c
> @@ -633,4 +633,5 @@ static struct kunit_suite string_test_suite = {
>  
>  kunit_test_suites(&string_test_suite);
>  
> +MODULE_DESCRIPTION("Test cases for string functions");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240531-md-lib-string-d987d813b344
> 

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.