linux-hardening - Re: [PATCH] wifi: iwlwifi: mvm: Fix __counted_by usage in cfg80211_wowlan_nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f7d2d25-5c7c-4a19-8af7-ce38ee630d4d@wanadoo.fr>
Date: Thu, 20 Jun 2024 20:53:45 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
 Kees Cook <kees@...nel.org>
Cc: benjamin.berg@...el.com, dmantipov@...dex.ru, gregory.greenman@...el.com,
 gustavoars@...nel.org, haim.dreyfuss@...el.com, johannes.berg@...el.com,
 kvalo@...nel.org, linux-hardening@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
 luciano.coelho@...el.com, miriam.rachel.korenblit@...el.com,
 shaul.triebitz@...el.com, yedidya.ben.shimol@...el.com
Subject: Re: [PATCH] wifi: iwlwifi: mvm: Fix __counted_by usage in
 cfg80211_wowlan_nd_*

Le 20/06/2024 à 20:08, Gustavo A. R. Silva a écrit :
> 
> 
> On 6/20/24 12:02, Gustavo A. R. Silva wrote:
>>
>>> My understanding is that 'match', is allocated by :
>>>      match = kzalloc(struct_size(match, channels, n_channels), 
>>> GFP_KERNEL);
>>>
>>> So match->n_channels is *0* when iwl_mvm_query_set_freqs() is called.
>>
>> n_channels is updated in the line before calling kzalloc():
>>
>> n_channels = iwl_mvm_query_num_match_chans(mvm, d3_data->nd_results, i);
>>
>> match = kzalloc(struct_size(match, channels, n_channels), GFP_KERNEL);
> 
> then match->n_channels updated here:
> 
>           if (!match)
>               goto out_report_nd;
> +        match->n_channels = n_channels;

Thanks for the explanation.
This is what I was looking for, and I missed this line.

Sorry for the noise.

CJ

> 
> Sorry about the split response, finger failure ugghh
> 
> -- 
> Gustavo
> 
>