linux-hardening - Re: [PATCH net-next] netdevice: define and allocate &net_device _properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZnV77C66v+uS9AhR@gmail.com>
Date: Fri, 21 Jun 2024 06:11:08 -0700
From: Breno Leitao <leitao@...ian.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>, kuba@...nel.org
Cc: Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Simon Horman <horms@...nel.org>,
	nex.sw.ncis.osdt.itp.upstreaming@...el.com,
	linux-hardening@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] netdevice: define and allocate &net_device
 _properly_

On Fri, Jun 14, 2024 at 05:00:54AM -0700, Breno Leitao wrote:
> On Wed, May 08, 2024 at 11:13:21AM +0200, Alexander Lobakin wrote:
> > From: Jakub Kicinski <kuba@...nel.org>
> > Date: Tue, 7 May 2024 11:10:35 -0700
> > 
> > > On Tue,  7 May 2024 14:39:37 +0200 Alexander Lobakin wrote:
> > >> There are several instances of the structure embedded into other
> > >> structures, but also there's ongoing effort to remove them and we
> > >> could in the meantime declare &net_device properly.
> > > 
> > > Is there a reason you're reposting this before that effort is completed?
> > 
> > To speed up the conversion probably :D
> > 
> > > The warnings this adds come from sparse and you think they should be
> > > ignored?
> > 
> > For now...
> > 
> > > 
> > > TBH since Breno is doing the heavy lifting of changing the embedders 
> > > it'd seem more fair to me if he got to send this at the end. Or at
> > > least, you know, got a mention or a CC.
> > 
> > I was lazy enough to add tags, sorry. The idea of him sending this at
> > the end sounds reasonable.
> 
> I think we are almost at the time to get rid of the last user of
> embedded netdev.
> 
> 	https://lore.kernel.org/all/20240614115317.657700-1-leitao@debian.org/
> 
> Once that patch lands, I will submit this patch on top of that final
> fix.

In fact, I jumped the gun, and reviewing the embedded users of
netdevice, I found there are three more devices, that will need some
care before we proceed

drivers/crypto/caam/caamalg_qi2.h:

  struct dpaa2_caam_priv_per_cpu {
	...
	struct net_device net_dev;


drivers/crypto/caam/qi.c:

  struct caam_qi_pcpu_priv {
	...
        struct net_device net_dev;

drivers/net/ethernet/cavium/thunder/thunder_bgx.c:

  struct lmac {
	...
        struct net_device       netdev;