linux-hardening - Re: [PATCH net-next v3] netdevice: define and allocate &net_device _properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172074723163.25041.6587317350607512702.git-patchwork-notify@kernel.org>
Date: Fri, 12 Jul 2024 01:20:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Breno Leitao <leitao@...ian.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, kees@...nel.org, gustavoars@...nel.org,
 keescook@...omium.org, horms@...nel.org, linux-hardening@...r.kernel.org,
 aleksander.lobakin@...el.com, przemyslaw.kitszel@...el.com, jiri@...nulli.us,
 bigeasy@...utronix.de, daniel@...earbox.net, lorenzo@...nel.org,
 johannes.berg@...el.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] netdevice: define and allocate &net_device
 _properly_

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 10 Jul 2024 04:30:28 -0700 you wrote:
> From: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> In fact, this structure contains a flexible array at the end, but
> historically its size, alignment etc., is calculated manually.
> There are several instances of the structure embedded into other
> structures, but also there's ongoing effort to remove them and we
> could in the meantime declare &net_device properly.
> Declare the array explicitly, use struct_size() and store the array
> size inside the structure, so that __counted_by() can be applied.
> Don't use PTR_ALIGN(), as SLUB itself tries its best to ensure the
> allocated buffer is aligned to what the user expects.
> Also, change its alignment from %NETDEV_ALIGN to the cacheline size
> as per several suggestions on the netdev ML.
> 
> [...]

Here is the summary with links:
  - [net-next,v3] netdevice: define and allocate &net_device _properly_
    https://git.kernel.org/netdev/net-next/c/13cabc47f8ae

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html