linux-hardening - Re: [PATCH v2] printk: Add a short description string to kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y1664wzl.fsf@mail.lhotse>
Date: Fri, 12 Jul 2024 22:26:38 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Jocelyn Falempe <jfalempe@...hat.com>, Nicholas Piggin
 <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Miquel Raynal
 <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh
 Raghavendra <vigneshr@...com>, Kees Cook <kees@...nel.org>, Tony Luck
 <tony.luck@...el.com>, "Guilherme G. Piccoli" <gpiccoli@...lia.com>, Petr
 Mladek <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>, John
 Ogness <john.ogness@...utronix.de>, Sergey Senozhatsky
 <senozhatsky@...omium.org>, Jocelyn Falempe <jfalempe@...hat.com>, Andrew
 Morton <akpm@...ux-foundation.org>, Jani Nikula <jani.nikula@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kefeng Wang
 <wangkefeng.wang@...wei.com>, Thomas Gleixner <tglx@...utronix.de>, Uros
 Bizjak <ubizjak@...il.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-hyperv@...r.kernel.org, linux-mtd@...ts.infradead.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] printk: Add a short description string to kmsg_dump()

Jocelyn Falempe <jfalempe@...hat.com> writes:
> kmsg_dump doesn't forward the panic reason string to the kmsg_dumper
> callback.
> This patch adds a new struct kmsg_dump_detail, that will hold the
> reason and description, and pass it to the dump() callback.
>
> To avoid updating all kmsg_dump() call, it adds a kmsg_dump_desc()
> function and a macro for backward compatibility.
>
> I've written this for drm_panic, but it can be useful for other
> kmsg_dumper.
> It allows to see the panic reason, like "sysrq triggered crash"
> or "VFS: Unable to mount root fs on xxxx" on the drm panic screen.
>
> v2:
>  * Use a struct kmsg_dump_detail to hold the reason and description
>    pointer, for more flexibility if we want to add other parameters.
>    (Kees Cook)
>  * Fix powerpc/nvram_64 build, as I didn't update the forward
>    declaration of oops_to_nvram()
>
> Signed-off-by: Jocelyn Falempe <jfalempe@...hat.com>
> ---
>  arch/powerpc/kernel/nvram_64.c             |  8 ++++----
>  arch/powerpc/platforms/powernv/opal-kmsg.c |  4 ++--

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers