linux-hardening - Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <108448f5-912f-4dac-bbba-19b1b58087b1@leemhuis.info>
Date: Tue, 23 Jul 2024 12:04:41 +0200
From: Thorsten Leemhuis <regressions@...mhuis.info>
To: Greg KH <gregkh@...uxfoundation.org>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc: "Darrick J. Wong" <djwong@...nel.org>, "Artem S. Tashkinov"
 <aros@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 linux-ext4@...r.kernel.org, xcreativ@...il.com, madeisbaer@...or.de,
 justinstitt@...gle.com, keescook@...omium.org,
 linux-hardening@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
 Kees Cook <kees@...nel.org>,
 Linux kernel regressions list <regressions@...ts.linux.dev>
Subject: Re: Linux 6.10 regression resulting in a crash when using an ext4
 filesystem

On 23.07.24 06:11, Theodore Ts'o wrote:
> On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
>>> Is strscpy_pad appropriate if the @src parameter itself is a fixed
>>> length char[16] which isn't null terminated when the label itself is 16
>>> chars long?
>>
>> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
> 
> Yeah, sorry, I was on vacation for 3.5 weeks starting just before
> Memorial day, and it took me a while to get caught up.  Unfortunately,
> I missed the bug in the strncpy extirpation patch, and it was't
> something that our regression tests caught.  (Sometimes, the
> old/deprecated ways are just more reliable; all of ext4's strncpy()
> calls were working and had been correct for decades.  :-P )
> 
> Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be
> making its way to -stable.

Adding Greg and the stable list to the list of recipients: given that we
already have two reports about trouble due to this[1] he might want to
fast-track the fix (be27cd64461c45 ("ext4: use memtostr_pad() for
s_volume_name")) to 6.10.y, as it's not queued yet -- at least afaics
from looking at
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/

Ciao, Thorsten

[1] https://bugzilla.kernel.org/show_bug.cgi?id=219072 and
https://bugzilla.kernel.org/show_bug.cgi?id=219078