linux-hardening - Re: [PATCH] ext4: Annotate struct ext4_xattr_inode_array with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <08F6527F-726D-4A3F-96B3-2C3712336D5C@toblux.com>
Date: Tue, 30 Jul 2024 19:10:28 +0200
From: Thorsten Blum <thorsten.blum@...lux.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: tytso@....edu,
 adilger.kernel@...ger.ca,
 kees@...nel.org,
 gustavoars@...nel.org,
 linux-ext4@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ext4: Annotate struct ext4_xattr_inode_array with
 __counted_by()

On 29. Jul 2024, at 16:09, Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:
> On 29/07/24 05:04, Thorsten Blum wrote:
>> Add the __counted_by compiler attribute to the flexible array member
>> inodes to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
>> CONFIG_FORTIFY_SOURCE.
> 
> This change seems to be incomplete. The relationship between `count` and
> accesses to `inodes` should be adjusted at least in `ext4_expand_inode_array()`
> 
> See this for more details:
> 
> https://embeddedor.com/blog/2024/06/18/how-to-use-the-new-counted_by-attribute-in-c-and-linux/

Thanks. I'll submit a v2 shortly.

Thorsten