linux-hardening - Re: [PATCH v2] net: core: annotate socks of struct sock_reuseport with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240731165029.5f4b4e60@kernel.org>
Date: Wed, 31 Jul 2024 16:50:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Paolo Abeni <pabeni@...hat.com>, "Gustavo A . R . Silva"
 <gustavo@...eddedor.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, Kees Cook
 <kees@...nel.org>, netdev@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] net: core: annotate socks of struct sock_reuseport
 with __counted_by

On Wed, 31 Jul 2024 07:53:46 +0300 Dmitry Antipov wrote:
> +	reuse = kzalloc(struct_size(reuse, socks, max_socks), GFP_ATOMIC);
>  
>  	if (!reuse)

another nit -- no empty lines between function call and its error check
:)

Two bits of docs to look at before sending v3:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
-- 
pw-bot: cr