linux-hardening - Re: [PATCH] crypto: chacha20poly1305 - Annotate struct chachapoly_ctx with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408051344.140B713E4C@keescook>
Date: Mon, 5 Aug 2024 13:49:38 -0700
From: Kees Cook <kees@...nel.org>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, gustavoars@...nel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] crypto: chacha20poly1305 - Annotate struct
 chachapoly_ctx with __counted_by()

On Mon, Aug 05, 2024 at 07:52:38PM +0200, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> salt to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
> 
> Use struct_size_t() instead of manually calculating the struct's size.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  crypto/chacha20poly1305.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/chacha20poly1305.c b/crypto/chacha20poly1305.c
> index 9e4651330852..b37f59a8280a 100644
> --- a/crypto/chacha20poly1305.c
> +++ b/crypto/chacha20poly1305.c
> @@ -27,7 +27,7 @@ struct chachapoly_ctx {
>  	struct crypto_ahash *poly;
>  	/* key bytes we use for the ChaCha20 IV */
>  	unsigned int saltlen;
> -	u8 salt[];
> +	u8 salt[] __counted_by(saltlen);
>  };

AFAICT, all the allocations of struct chachapoly_ctx set "saltlen" before
using "salt".

Reviewed-by: Kees Cook <kees@...nel.org>

>  
>  struct poly_req {
> @@ -611,8 +611,8 @@ static int chachapoly_create(struct crypto_template *tmpl, struct rtattr **tb,
>  				       poly->base.cra_priority) / 2;
>  	inst->alg.base.cra_blocksize = 1;
>  	inst->alg.base.cra_alignmask = chacha->base.cra_alignmask;
> -	inst->alg.base.cra_ctxsize = sizeof(struct chachapoly_ctx) +
> -				     ctx->saltlen;
> +	inst->alg.base.cra_ctxsize = struct_size_t(struct chachapoly_ctx, salt,
> +						   ctx->saltlen);
>  	inst->alg.ivsize = ivsize;
>  	inst->alg.chunksize = chacha->chunksize;
>  	inst->alg.maxauthsize = POLY1305_DIGEST_SIZE;

My instinct is to use struct_size_t() as little as possible (compared
to normal struct_size), since I prefer to use it where a thing is being
allocated. (In this case, it's "far away".) So given Eric already thinks
this part should be dropped, I would agree: leave this as is.

-- 
Kees Cook