linux-hardening - Re: [PATCH] btrfs: Annotate structs with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7cbec5f-269a-410c-bb5a-e00de15078f6@wdc.com>
Date: Mon, 12 Aug 2024 10:54:49 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Thorsten Blum <thorsten.blum@...lux.com>, "clm@...com" <clm@...com>,
	"josef@...icpanda.com" <josef@...icpanda.com>, "dsterba@...e.com"
	<dsterba@...e.com>, "kees@...nel.org" <kees@...nel.org>,
	"gustavoars@...nel.org" <gustavoars@...nel.org>
CC: "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH] btrfs: Annotate structs with __counted_by()

On 12.08.24 12:37, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> stripes to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>   fs/btrfs/volumes.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 37a09ebb34dd..f28fa318036b 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -551,7 +551,7 @@ struct btrfs_io_context {
>   	 * stripes[data_stripes + 1]:	The Q stripe (only for RAID6).
>   	 */
>   	u64 full_stripe_logical;
> -	struct btrfs_io_stripe stripes[];
> +	struct btrfs_io_stripe stripes[] __counted_by(num_stripes);
>   };
>   
>   struct btrfs_device_info {
> @@ -591,7 +591,7 @@ struct btrfs_chunk_map {
>   	int io_width;
>   	int num_stripes;
>   	int sub_stripes;
> -	struct btrfs_io_stripe stripes[];
> +	struct btrfs_io_stripe stripes[] __counted_by(num_stripes);
>   };
>   
>   #define btrfs_chunk_map_size(n) (sizeof(struct btrfs_chunk_map) + \

Looks good to me,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>

Out of curiosity, have you encountered any issues with this patch applied?