linux-hardening - Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95143a74-fc99-44c5-b531-7ee6592e90fd@jiaxyga.com>
Date: Sat, 17 Aug 2024 21:09:36 +0300
From: Danila Tikhonov <danila@...xyga.com>
To: Rob Herring <robh@...nel.org>
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
 konradybcio@...nel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, rafael@...nel.org,
 viresh.kumar@...aro.org, kees@...nel.org, tony.luck@...el.com,
 gpiccoli@...lia.com, ulf.hansson@...aro.org, andre.przywara@....com,
 quic_rjendra@...cinc.com, davidwronek@...il.com, neil.armstrong@...aro.org,
 heiko.stuebner@...rry.de, rafal@...ecki.pl, macromorgan@...mail.com,
 linus.walleij@...aro.org, lpieralisi@...nel.org,
 dmitry.baryshkov@...aro.org, fekz115@...il.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 netdev@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-hardening@...r.kernel.org, danila@...xyga.com
Subject: Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree

On 8/9/24 00:38, Rob Herring wrote:
> On Thu, Aug 08, 2024 at 09:40:22PM +0300, Danila Tikhonov wrote:
>> From: Eugene Lepshy <fekz115@...il.com>
>>
>> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
>> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>>
>> It uses the Kryo670.
>>
>> Signed-off-by: Eugene Lepshy <fekz115@...il.com>
>> Signed-off-by: Danila Tikhonov <danila@...xyga.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> new file mode 100644
>> index 000000000000..5b4574484412
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024, Eugene Lepshy <fekz115@...il.com>
>> + * Copyright (c) 2024, Danila Tikhonov <danila@...xyga.com>
>> + */
>> +
>> +#include "sc7280.dtsi"
>> +
>> +/* SM7325 uses Kryo 670 */
>> +&CPU0 { compatible = "qcom,kryo670"; };
>> +&CPU1 { compatible = "qcom,kryo670"; };
>> +&CPU2 { compatible = "qcom,kryo670"; };
>> +&CPU3 { compatible = "qcom,kryo670"; };
>> +&CPU4 { compatible = "qcom,kryo670"; };
>> +&CPU5 { compatible = "qcom,kryo670"; };
>> +&CPU6 { compatible = "qcom,kryo670"; };
>> +&CPU7 { compatible = "qcom,kryo670"; };
> No PMU? Because PMUs are also a per CPU model compatible string.
>
> I fixed most QCom platforms recently.
>
> Rob
Sorry for my long reply and thank you for your feedback.

You are absolutely right. But at the moment I can't confirm that the
sc7280 doesn't use cortex a55 and a78 either. I would fix that in the
sc7280 DTS right away if I could confirm it. I am almost certain that
the qcm6490 uses cortex a55 and a78 just like the sm7325 (and I
hope Luca Weiss can confirm that too)

If anyone with a sc7280 can read /proc/cpuinfo I would be very grateful.

Best wishes,
Danila