linux-hardening - Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsKiC+MSWbAOxxDA@xsang-OptiPlex-9020>
Date: Mon, 19 Aug 2024 09:38:19 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Jeff Xu <jeffxu@...gle.com>
CC: Jeff Xu <jeffxu@...omium.org>, <akpm@...ux-foundation.org>,
	<willy@...radead.org>, <torvalds@...ux-foundation.org>,
	<Liam.Howlett@...cle.com>, <pedro.falcato@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-hardening@...r.kernel.org>,
	<lorenzo.stoakes@...cle.com>, <mpe@...erman.id.au>, <vbabka@...e.cz>,
	<keescook@...omium.org>, <oliver.sang@...el.com>
Subject: Re: [PATCH v1 0/2] mremap refactor: check src address for vma
 boundaries first.

hi, Jeff,

On Sun, Aug 18, 2024 at 05:28:41PM +0800, Oliver Sang wrote:
> hi, Jeff,
> 
> On Thu, Aug 15, 2024 at 07:58:57PM -0700, Jeff Xu wrote:
> > Hi Oliver
> 
> [...]
> 
> > > could you exlictly point to two commit-id?
> > sure
> > 
> > this patch
> > 8be7258a: mseal: add mseal syscall
> > ff388fe5c: mseal: wire up mseal syscall
> 
> I failed to apply this patch set to "8be7258a: mseal: add mseal syscall"

look your patch set again
[PATCH v1 1/2] mseal:selftest mremap across VMA boundaries
just for kselftests

and I can apply
[PATCH v1 2/2] mseal: refactor mremap to remove can_modify_mm
upon "8be7258a: mseal: add mseal syscall" cleanly

so I will start test for this [PATCH v1 2/2]

BTW, I will firstly use our default setting - "60s testtime; reboot between each
run; run 10 times", since we've already have the data for 8be7258a and ff388fe5c
then we could give you an update kind of quickly.

as some private mail discussed, you want some special run method, could you
elaborate them here? thanks


> 
> to avoid the impact of other changes, better to apply the patch upon 8be7258a
> directly.
> 
> if you prefer other base for this patch, please let us know. then we will
> supply the results for 4 commits in fact:
> 
> this patch
> the base of this patch
> 8be7258a: mseal: add mseal syscall
> ff388fe5c: mseal: wire up mseal syscall
> 
> > 
> > > >
> > > > Thank you for your time and assistance in helping me on understanding
> > > > this issue.
> > >
> > > due to resource constraint, please expect that we need several days to finish
> > > this test request.
> > No problem.
> > 
> > Thanks for your help!
> > -Jeff
> > 
> > > >
> > > > Best regards,
> > > > -Jeff
> > > >
> > > > > -Jeff
> > > > >
> > > > > > [1] https://lore.kernel.org/lkml/202408041602.caa0372-oliver.sang@intel.com/
> > > > > > [2] https://github.com/peaktocreek/mmperf/blob/main/run_stress_ng.c
> > > > > >
> > > > > >
> > > > > > Jeff Xu (2):
> > > > > >   mseal:selftest mremap across VMA boundaries.
> > > > > >   mseal: refactor mremap to remove can_modify_mm
> > > > > >
> > > > > >  mm/internal.h                           |  24 ++
> > > > > >  mm/mremap.c                             |  77 +++----
> > > > > >  mm/mseal.c                              |  17 --
> > > > > >  tools/testing/selftests/mm/mseal_test.c | 293 +++++++++++++++++++++++-
> > > > > >  4 files changed, 353 insertions(+), 58 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.46.0.76.ge559c4bf1a-goog
> > > > > >