linux-hardening - Re: [PATCH -next v3 3/3] nfs make use of str_false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs1JAfGWQOZMfHKT@casper.infradead.org>
Date: Tue, 27 Aug 2024 04:33:21 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: kees@...nel.org, andy@...nel.org, akpm@...ux-foundation.org,
	trondmy@...nel.org, anna@...nel.org, gregkh@...uxfoundation.org,
	linux-hardening@...r.kernel.org, linux-mm@...ck.org,
	linux-nfs@...r.kernel.org
Subject: Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper

On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote:
> The helper str_false_true is introduced to reback "false/true"
> string literal. We can simplify this format by str_false_true.

This seems unnecessarily verbose & complex.  How about:

	dprintk("%s: link support=%s\n", __func__, strbool(*res != 0));

> -	dprintk("%s: link support=%s\n", __func__, *res == 0 ? "false" : "true");
> +	dprintk("%s: link support=%s\n", __func__, str_false_true(*res == 0));

(do we have a convention for the antonym of kstrtoX?)