[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240829112455.232263-3-lihongbo22@huawei.com>
Date: Thu, 29 Aug 2024 19:24:55 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: <kees@...nel.org>, <andy@...nel.org>, <Julia.Lawall@...ia.fr>,
<nicolas.palix@...g.fr>
CC: <linux-hardening@...r.kernel.org>, <cocci@...ia.fr>,
<lihongbo22@...wei.com>
Subject: [PATCH -next 2/2] coccinelle: Add rules to find str_false_true() replacements
As done with str_true_false(), add checks for str_false_true()
opportunities. A simple test can find over 9 cases currently
exist in the tree.
Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
---
scripts/coccinelle/api/string_choices.cocci | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci
index 50329c4c8acd..a1141bd29b3c 100644
--- a/scripts/coccinelle/api/string_choices.cocci
+++ b/scripts/coccinelle/api/string_choices.cocci
@@ -108,3 +108,26 @@ e << str_true_false_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_true_false(%s)" % e)
+
+@..._false_true depends on patch@
+expression E;
+@@
+(
+- ((E) ? "false" : "true")
++ str_false_true(E)
+)
+
+@..._false_true_r depends on !patch exists@
+expression E;
+position P;
+@@
+(
+* ((E@P) ? "false" : "true")
+)
+
+@...ipt:python depends on report@
+p << str_false_true_r.P;
+e << str_false_true_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_false_true(%s)" % e)
--
2.34.1
Powered by blists - more mailing lists