lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9d844c72-bda6-4e28-b48c-63c4f8855ae7@huawei.com> Date: Tue, 3 Sep 2024 14:25:53 +0800 From: Hongbo Li <lihongbo22@...wei.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, Andy Shevchenko <andy@...nel.org>, Jakub Kicinski <kuba@...nel.org> CC: <kees@...nel.org>, <jasowang@...hat.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, <akpm@...ux-foundation.org>, <linux-hardening@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-mm@...ck.org> Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper On 2024/9/2 22:30, Willem de Bruijn wrote: > Andy Shevchenko wrote: >> On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote: >>> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: >>>> Use str_disabled_enabled() helper instead of open >>>> coding the same. >> >> ... >> >>>> netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", >>>> - arg ? "disabled" : "enabled"); >>>> + str_disabled_enabled(arg)); >>> >>> You don't explain the 'why'. How is this an improvement? >>> nack on this and 2 similar networking changes you sent >> >> Side opinion: This makes the messages more unified and not prone to typos >> and/or grammatical mistakes. Unification allows to shrink binary due to >> linker efforts on string literals deduplication. > > This adds a layer of indirection. > > The original code is immediately obvious. When I see the new code I > have to take a detour through cscope to figure out what it does. If they have used it once, there is no need for more jumps, because it's relatively simple. Using a dedicated function seems very elegant and unified, especially for some string printing situations, such as disable/enable. Even in today's kernel tree, there are several different formats that appear: 'enable/disable', 'enabled/disabled', 'en/dis'. Thanks, Hongbo > > To me, in this case, the benefit is too marginal to justify that.
Powered by blists - more mailing lists