linux-hardening - Re: [PATCH -next] dmaengine: Loongson1: Annotate struct ls1x_dma_chan with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhJPsV75K=yawL-vV1MHbXNZssB3sphPjN4gPZN3EbASgzG4A@mail.gmail.com>
Date: Wed, 4 Sep 2024 10:25:45 +0800
From: Keguang Zhang <keguang.zhang@...il.com>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: vkoul@...nel.org, kees@...nel.org, gustavoars@...nel.org, 
	linux-mips@...r.kernel.org, dmaengine@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: Loongson1: Annotate struct ls1x_dma_chan
 with __counted_by()

On Wed, Sep 4, 2024 at 9:39 AM Hongbo Li <lihongbo22@...wei.com> wrote:
>
> Add the __counted_by compiler attribute to the flexible array member
> entries to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
>  drivers/dma/loongson1-apb-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/loongson1-apb-dma.c b/drivers/dma/loongson1-apb-dma.c
> index ca43c67a8203..be0dbda84dd2 100644
> --- a/drivers/dma/loongson1-apb-dma.c
> +++ b/drivers/dma/loongson1-apb-dma.c
> @@ -78,7 +78,7 @@ struct ls1x_dma_chan {
>  struct ls1x_dma {
>         struct dma_device ddev;
>         unsigned int nr_chans;
> -       struct ls1x_dma_chan chan[];
> +       struct ls1x_dma_chan chan[] __counted_by(nr_chans);
>  };
>
>  static irqreturn_t ls1x_dma_irq_handler(int irq, void *data);
> --
> 2.34.1
>

Reviewed-by: Keguang Zhang <keguang.zhang@...il.com>

-- 
Best regards,

Keguang Zhang