lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <172555507039.1959022.16303899697737520578.b4-ty@kernel.org> Date: Thu, 5 Sep 2024 09:51:14 -0700 From: Kees Cook <kees@...nel.org> To: Hongbo Li <lihongbo22@...wei.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: Kees Cook <kees@...nel.org>, andy@...nel.org, trondmy@...nel.org, anna@...nel.org, gregkh@...uxfoundation.org, linux-hardening@...r.kernel.org, linux-mm@...ck.org, linux-nfs@...r.kernel.org Subject: Re: (subset) [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper On Wed, 28 Aug 2024 13:25:09 -0700, Andrew Morton wrote: > On Wed, 28 Aug 2024 11:49:51 +0800 Hongbo Li <lihongbo22@...wei.com> wrote: > > > > Anything which is calling these functions is not performance-sensitive, > > > so optimizing for space is preferred. An out-of-line function which > > > returns a const char * will achieve this? > > I think this helper can achieve this. Because it is tiny enough, the > > compiler will handle this like #define macro (do the replacement) > > without allocating extra functional stack. On the contrary, if it is > > implemented as a non-inline function, it will cause extra functional > > stack when it was called every time. And it also should be implemented > > in a source file (.c file), not in header file(.h file). > > [...] Since I've taken over string maintainership, I've applied this to my tree (where other similar changes are appearing). This should reduce conflicts here... Applied to for-next/hardening, thanks! [1/3] lib/string_choices: Add str_true_false()/str_false_true() helper https://git.kernel.org/kees/c/6ff4cd1160af Take care, -- Kees Cook
Powered by blists - more mailing lists