linux-hardening - Re: [PATCH][next] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_cmd_802_11_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172588379395.2095526.695179874478539721.kvalo@kernel.org>
Date: Mon,  9 Sep 2024 12:09:55 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Brian Norris <briannorris@...omium.org>,
 Francesco Dolcini <francesco@...cini.it>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] wifi: mwifiex: Fix memcpy() field-spanning write
 warning in mwifiex_cmd_802_11_scan_ext()

"Gustavo A. R. Silva" <gustavoars@...nel.org> wrote:

> Replace one-element array with a flexible-array member in
> `struct host_cmd_ds_802_11_scan_ext`.
> 
> With this, fix the following warning:
> 
> elo 16 17:51:58 surfacebook kernel: ------------[ cut here ]------------
> elo 16 17:51:58 surfacebook kernel: memcpy: detected field-spanning write (size 243) of single field "ext_scan->tlv_buffer" at drivers/net/wireless/marvell/mwifiex/scan.c:2239 (size 1)
> elo 16 17:51:58 surfacebook kernel: WARNING: CPU: 0 PID: 498 at drivers/net/wireless/marvell/mwifiex/scan.c:2239 mwifiex_cmd_802_11_scan_ext+0x83/0x90 [mwifiex]
> 
> Reported-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Closes: https://lore.kernel.org/linux-hardening/ZsZNgfnEwOcPdCly@black.fi.intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Acked-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless-next.git, thanks.

498365e52beb wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_cmd_802_11_scan_ext()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/ZsZa5xRcsLq9D+RX@elsanto/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches