linux-hardening - Re: [PATCH v2] wifi: cfg80211: fix two more possible UBSAN-detected off-by-one errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409101727.2104D50D85@keescook>
Date: Tue, 10 Sep 2024 17:27:57 -0700
From: Kees Cook <kees@...nel.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Johannes Berg <johannes.berg@...el.com>, Kalle Valo <kvalo@...nel.org>,
	linux-wireless@...r.kernel.org, linux-hardening@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] wifi: cfg80211: fix two more possible UBSAN-detected
 off-by-one errors

On Mon, Sep 09, 2024 at 12:08:06PM +0300, Dmitry Antipov wrote:
> Although not reproduced in practice, these two cases may be
> considered by UBSAN as off-by-one errors. So fix them in the
> same way as in commit a26a5107bc52 ("wifi: cfg80211: fix UBSAN
> noise in cfg80211_wext_siwscan()").
> 
> Fixes: 807f8a8c3004 ("cfg80211/nl80211: add support for scheduled scans")
> Fixes: 5ba63533bbf6 ("cfg80211: fix alignment problem in scan request")
> Signed-off-by: Dmitry Antipov <dmantipov@...dex.ru>

Thanks for finding these!

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook