linux-hardening - Re: [PATCH][next] container_of: add container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <426c0507-be04-4b87-8595-0a6a740d4dfe@embeddedor.com>
Date: Sat, 21 Sep 2024 09:10:50 +0200
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Greg KH <gregkh@...uxfoundation.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] container_of: add container_first() macro

On 21/09/24 07:52, Greg KH wrote:
> On Sat, Sep 21, 2024 at 08:45:28AM +0300, Dan Carpenter wrote:
>> On Fri, Sep 20, 2024 at 02:50:02PM +0200, Gustavo A. R. Silva wrote:
>>> This is like container_of() but it has an assert to ensure that it's
>>> using the first struct member.
>>>
>>
>> I just remembered that Greg wanted this based on container_of_const().
> 
> Yes, that would be best.

Okay, I'll change that.

--
Gustavo

> 
>> Really container_of_const() should be renamed to container_of() and
>> container_of() should be renamed to container_of_helper() and we
>> would add a #define container_of_const container_of for the transition.
> 
> I agree, but I wonder if it's safe to just do that already and how many
> build warnings would happen.  Last I checked it was a lot.
> 
> thanks,
> 
> greg k-h
>