lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240929211045.GA2111654@thelio-3990X> Date: Sun, 29 Sep 2024 14:10:45 -0700 From: Nathan Chancellor <nathan@...nel.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev, patches@...ts.linux.dev Subject: Re: [PATCH] hardening: Adjust dependencies in selection of MODVERSIONS On Sun, Sep 29, 2024 at 08:35:44AM -0700, Linus Torvalds wrote: > On Sat, 28 Sept 2024 at 11:13, Nathan Chancellor <nathan@...nel.org> wrote: > > > > MODVERSIONS recently grew a dependency on !COMPILE_TEST so that Rust > > could be more easily tested. However, this introduces a Kconfig warning > > when building allmodconfig with a clang version that supports RANDSTRUCT > > natively because RANDSTRUCT_FULL and RANDSTRUCT_PERFORMANCE select > > MODVERSIONS when MODULES is enabled, bypassing the !COMPILE_TEST > > dependency: > > Argh. I should have checked, but I didn't think anybody would 'select' > MODVERSIONS. > > That's such an odd thing to do in general, but I guess for RANDSTRUCT > it actually makes sense (since a plain version check is nonsensical). > > Now that 'select' statement is truly crazy and another level of odd > duck, but I guess it still makes perfect sense ("give me the build > coverage, but this is never going to be run, so don't bother with > MODVERSIONS"). Yeah, I came to the same conclusion on both fronts (perhaps I should have actually put that in the patch description). > So Ack on the patch. And now I did check that there doesn't seem to be > anything else with odd MODVERSIONS Kconfig rules. Thanks, it looks like you'll get this via Kees soon. Cheers, Nathan
Powered by blists - more mailing lists