linux-hardening - Re: [RFC PATCH 11/11] kbuild: suppress echoing of commands in --dry-run mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241114-rich-free-hound-6aa0bd@lindesnes>
Date: Thu, 14 Nov 2024 11:49:30 +0100
From: Nicolas Schier <nicolas@...sle.eu>
To: Vegard Nossum <vegard.nossum@...cle.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Morten Linderud <morten@...derud.pw>,
	Haelwenn Monnier <contact@...odan.eu>, Jann Horn <jannh@...gle.com>,
	Kees Cook <kees@...nel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Theodore Ts'o <tytso@....edu>, linux-hardening@...r.kernel.org
Subject: Re: [RFC PATCH 11/11] kbuild: suppress echoing of commands in
 --dry-run mode

On Mon, Aug 19, 2024 at 06:03:08PM +0200, Vegard Nossum wrote:
> If the user ran 'make -n' then we will already print all commands.
> 
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
> ---
>  Makefile | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d08ade5791c2e..a1a3e96a10ea2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -96,9 +96,10 @@ ifneq ($(findstring 1, $(KBUILD_VERBOSE)),)
>    Q =
>  endif
>  
> -# If the user is running make -s (silent mode), suppress echoing of
> -# commands
> -ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),)
> +# If the user is running make -s (silent mode) or -n (dry run mode),
> +# suppress echoing of commands
> +ifneq (,$(or $(findstring s,$(firstword -$(MAKEFLAGS))), \
> +	$(findstring n,$(firstword -$(MAKEFLAGS)))))
>  quiet=silent_
>  override KBUILD_VERBOSE :=
>  endif
> -- 
> 2.34.1
> 

I think it makes sense to apply this patch earlier.

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>