linux-hardening - Re: [PATCH] kernel/audit: Use __struct_size replace __member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhQ4gffqTJ7-aGy+kzP3kR7TMWcxOfQkqXygmgDr2bSOeQ@mail.gmail.com>
Date: Tue, 3 Dec 2024 18:18:38 -0500
From: Paul Moore <paul@...l-moore.com>
To: 15074444048@....com
Cc: audit@...r.kernel.org, eparis@...hat.com, lihaojie <lihaojie@...inos.cn>, 
	Kees Cook <kees@...nel.org>, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] kernel/audit: Use __struct_size replace __member_size

On Mon, Dec 2, 2024 at 10:18 PM <15074444048@....com> wrote:
>
> From: lihaojie <lihaojie@...inos.cn>
>
> Size of destnation less of the size to be written will
> make future warnings, the size of destnation should be
> complete
>
> Signed-off-by: lihaojie <lihaojie@...inos.cn>
> ---
>  include/linux/fortify-string.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This isn't an audit change, this is a FORTIFY_SOURCE change and should
go to the maintainer and mailing list documented in the MAINTAINERS
file (both added to this reply).

> diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h
> index 0d99bf11d260..0504b2c8aab7 100644
> --- a/include/linux/fortify-string.h
> +++ b/include/linux/fortify-string.h
> @@ -277,7 +277,7 @@ extern ssize_t __real_strscpy(char *, const char *, size_t) __RENAME(sized_strsc
>  __FORTIFY_INLINE ssize_t sized_strscpy(char * const POS p, const char * const POS q, size_t size)
>  {
>         /* Use string size rather than possible enclosing struct size. */
> -       const size_t p_size = __member_size(p);
> +       const size_t p_size = __struct_size(p);
>         const size_t q_size = __member_size(q);
>         size_t len;
>
> --
> 2.25.1

-- 
paul-moore.com