linux-hardening - Re: [PATCH] wifi: cfg80211: Move cfg80211_scan_req_add_chan() n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68b4d078-f275-4e42-8eba-e6002bd3db59@embeddedor.com>
Date: Mon, 30 Dec 2024 12:58:46 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <kees@...nel.org>, Johannes Berg <johannes@...solutions.net>
Cc: John Rowley <lkml@...nrowley.me>, Dmitry Antipov <dmantipov@...dex.ru>,
 Nathan Chancellor <nathan@...nel.org>, linux-wireless@...r.kernel.org,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: Move cfg80211_scan_req_add_chan()
 n_channels increment earlier



On 30/12/24 12:36, Kees Cook wrote:
> Since adding __counted_by(n_channels) to struct cfg80211_scan_request,
> anything adding to the channels array must increment n_channels first.
> Move n_channels increment earlier.
> 
> Reported-by: John Rowley <lkml@...nrowley.me>
> Closes: https://lore.kernel.org/stable/1815535c709ba9d9.156c6a5c9cdf6e59.b249b6b6a5ee4634@localhost.localdomain/
> Fixes: aa4ec06c455d ("wifi: cfg80211: use __counted_by where appropriate")
> Signed-off-by: Kees Cook <kees@...nel.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

-Gustavo

> ---
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Dmitry Antipov <dmantipov@...dex.ru>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> ---
>   net/wireless/scan.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index 1c6fd45aa809..ccdbeb604639 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -763,12 +763,11 @@ static  void cfg80211_scan_req_add_chan(struct cfg80211_scan_request *request,
>   		}
>   	}
>   
> +	request->n_channels++;
>   	request->channels[n_channels] = chan;
>   	if (add_to_6ghz)
>   		request->scan_6ghz_params[request->n_6ghz_params].channel_idx =
>   			n_channels;
> -
> -	request->n_channels++;
>   }
>   
>   static bool cfg80211_find_ssid_match(struct cfg80211_colocated_ap *ap,