linux-hardening - Re: [PATCH v4 25/30] context_tracking,x86: Defer kernel text patching IPIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c298b9e-d7c2-4a27-b993-e3bca28f8237@amd.com>
Date: Fri, 24 Jan 2025 16:18:19 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Valentin Schneider <vschneid@...hat.com>, <linux-kernel@...r.kernel.org>,
	<x86@...nel.org>, <virtualization@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <loongarch@...ts.linux.dev>,
	<linux-riscv@...ts.infradead.org>, <linux-perf-users@...r.kernel.org>,
	<xen-devel@...ts.xenproject.org>, <kvm@...r.kernel.org>,
	<linux-arch@...r.kernel.org>, <rcu@...r.kernel.org>,
	<linux-hardening@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-kselftest@...r.kernel.org>, <bpf@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>
CC: Peter Zijlstra <peterz@...radead.org>, Nicolas Saenz Julienne
	<nsaenzju@...hat.com>, Juergen Gross <jgross@...e.com>, Ajay Kaher
	<ajay.kaher@...adcom.com>, Alexey Makhalov <alexey.amakhalov@...adcom.com>,
	Russell King <linux@...linux.org.uk>, Catalin Marinas
	<catalin.marinas@....com>, Will Deacon <will@...nel.org>, Huacai Chen
	<chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
	<mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
	<dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>, Arnaldo
 Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Mark
 Rutland <mark.rutland@....com>, Alexander Shishkin
	<alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian
 Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, "Liang,
 Kan" <kan.liang@...ux.intel.com>, Boris Ostrovsky
	<boris.ostrovsky@...cle.com>, Josh Poimboeuf <jpoimboe@...nel.org>, Pawan
 Gupta <pawan.kumar.gupta@...ux.intel.com>, Sean Christopherson
	<seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>, Andy Lutomirski
	<luto@...nel.org>, Arnd Bergmann <arnd@...db.de>, Frederic Weisbecker
	<frederic@...nel.org>, "Paul E. McKenney" <paulmck@...nel.org>, Jason Baron
	<jbaron@...mai.com>, Steven Rostedt <rostedt@...dmis.org>, Ard Biesheuvel
	<ardb@...nel.org>, Neeraj Upadhyay <neeraj.upadhyay@...nel.org>, Joel
 Fernandes <joel@...lfernandes.org>, Josh Triplett <josh@...htriplett.org>,
	Boqun Feng <boqun.feng@...il.com>, Uladzislau Rezki <urezki@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Lai Jiangshan
	<jiangshanlai@...il.com>, Zqiang <qiang.zhang1211@...il.com>, Juri Lelli
	<juri.lelli@...hat.com>, Clark Williams <williams@...hat.com>, Yair Podemsky
	<ypodemsk@...hat.com>, Tomas Glozar <tglozar@...hat.com>, Vincent Guittot
	<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Kees Cook
	<kees@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Christoph
 Hellwig <hch@...radead.org>, Shuah Khan <shuah@...nel.org>, Sami Tolvanen
	<samitolvanen@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Alice Ryhl
	<aliceryhl@...gle.com>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>, Samuel
 Holland <samuel.holland@...ive.com>, Rong Xu <xur@...gle.com>, Geert
 Uytterhoeven <geert@...ux-m68k.org>, Yosry Ahmed <yosryahmed@...gle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, "Masami Hiramatsu
 (Google)" <mhiramat@...nel.org>, Jinghao Jia <jinghao7@...inois.edu>, Luis
 Chamberlain <mcgrof@...nel.org>, Randy Dunlap <rdunlap@...radead.org>, Tiezhu
 Yang <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH v4 25/30] context_tracking,x86: Defer kernel text patching
 IPIs

Hello Valentin,

On 1/14/2025 11:21 PM, Valentin Schneider wrote:
> [..snip..]
> diff --git a/include/linux/context_tracking_work.h b/include/linux/context_tracking_work.h
> index c68245f8d77c5..931ade1dcbcc2 100644
> --- a/include/linux/context_tracking_work.h
> +++ b/include/linux/context_tracking_work.h
> @@ -5,12 +5,12 @@
>   #include <linux/bitops.h>
>   
>   enum {
> -	CT_WORK_n_OFFSET,
> +	CT_WORK_SYNC,

nit.

Shouldn't this be "CT_WORK_SYNC_OFFSET"?

I believe it gets fixed in Patch 29/30 when "CT_WORK_TLBI_OFFSET" is
added but perhaps that can be moved here to preserve bisection.

>   	CT_WORK_MAX_OFFSET
>   };
>   
>   enum ct_work {
> -	CT_WORK_n        = BIT(CT_WORK_n_OFFSET),
> +	CT_WORK_SYNC     = BIT(CT_WORK_SYNC_OFFSET),
>   	CT_WORK_MAX      = BIT(CT_WORK_MAX_OFFSET)
>   };
>   

-- 
Thanks and Regards,
Prateek