Message-ID: <Z5eJJ199QwL0HVJT@smile.fi.intel.com>
Date: Mon, 27 Jan 2025 15:24:55 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Michael Ellerman <mpe@...erman.id.au>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Damien Le Moal <dlemoal@...nel.org>, Jiri Kosina <jikos@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Corey Minyard <minyard@....org>, Peter Huewe <peterhuewe@....de>,
	Jarkko Sakkinen <jarkko@...nel.org>,
	Tero Kristo <kristo@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Len Brown <lenb@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	John Allen <john.allen@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Vinod Koul <vkoul@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Moritz Fischer <mdf@...nel.org>, Liviu Dudau <liviu.dudau@....com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Andi Shyti <andi.shyti@...nel.org>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Peter Rosin <peda@...ntia.se>, Lars-Peter Clausen <lars@...afoo.de>,
	Jonathan Cameron <jic23@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Markuss Broks <markuss.broks@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Lee Jones <lee@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Iyappan Subramanian <iyappan@...amperecomputing.com>,
	Yisen Zhuang <yisen.zhuang@...wei.com>,
	Stanislaw Gruszka <stf_xl@...pl>, Kalle Valo <kvalo@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Tony Lindgren <tony@...mide.com>, Mark Brown <broonie@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Xiang Chen <chenxiang66@...ilicon.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Vaibhav Hiremath <hvaibhav.linux@...il.com>,
	Alex Elder <elder@...nel.org>, Jiri Slaby <jirislaby@...nel.org>,
	Jacky Huang <ychuang3@...oton.com>, Helge Deller <deller@....de>,
	Christoph Hellwig <hch@....de>, Robin Murphy <robin.murphy@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kees Cook <keescook@...omium.org>,
	Trond Myklebust <trond.myklebust@...merspace.com>,
	Anna Schumaker <anna@...nel.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Takashi Iwai <tiwai@...e.com>, linuxppc-dev@...ts.ozlabs.org,
	linux-ide@...r.kernel.org, openipmi-developer@...ts.sourceforge.net,
	linux-integrity@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-efi@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-fpga@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	linux-input@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-leds@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-rtc@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-amlogic@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-serial@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
	iommu@...ts.linux.dev, linux-trace-kernel@...r.kernel.org,
	kasan-dev@...glegroups.com, linux-hardening@...r.kernel.org,
	linux-nfs@...r.kernel.org, linux-kbuild@...r.kernel.org,
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 00/34] address all -Wunused-const warnings

On Wed, Apr 03, 2024 at 10:06:18AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compilers traditionally warn for unused 'static' variables, but not
> if they are constant. The reason here is a custom for C++ programmers
> to define named constants as 'static const' variables in header files
> instead of using macros or enums.
> 
> In W=1 builds, we get warnings only static const variables in C
> files, but not in headers, which is a good compromise, but this still
> produces warning output in at least 30 files. These warnings are
> almost all harmless, but also trivial to fix, and there is no
> good reason to warn only about the non-const variables being unused.
> 
> I've gone through all the files that I found using randconfig and
> allmodconfig builds and created patches to avoid these warnings,
> with the goal of retaining a clean build once the option is enabled
> by default.
> 
> Unfortunately, there is one fairly large patch ("drivers: remove
> incorrect of_match_ptr/ACPI_PTR annotations") that touches
> 34 individual drivers that all need the same one-line change.
> If necessary, I can split it up by driver or by subsystem,
> but at least for reviewing I would keep it as one piece for
> the moment.
> 
> Please merge the individual patches through subsystem trees.
> I expect that some of these will have to go through multiple
> revisions before they are picked up, so anything that gets
> applied early saves me from resending.

Arnd, can you refresh this one? It seems some misses still...
I have got 3+ 0-day reports against one of the mux drivers.

https://lore.kernel.org/all/?q=adg792a.c

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists