linux-hardening - Re: [GIT PULL] sysctl constification changes for v6.14-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgNwJ57GtPM_ZUCGeVN5iJt0pxDf96dRwp0KhuVV4Hjpw@mail.gmail.com>
Date: Wed, 29 Jan 2025 10:48:02 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Joel Granados <joel.granados@...nel.org>
Cc: Anna Schumaker <anna.schumaker@...cle.com>, Ashutosh Dixit <ashutosh.dixit@...el.com>, 
	Baoquan He <bhe@...hat.com>, "Bill O'Donnell" <bodonnel@...hat.com>, 
	Corey Minyard <cminyard@...sta.com>, "Darrick J. Wong" <djwong@...nel.org>, 
	Jani Nikula <jani.nikula@...el.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Song Liu <song@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Wei Liu <wei.liu@...nel.org>, Kees Cook <kees@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [GIT PULL] sysctl constification changes for v6.14-rc1

On Wed, 29 Jan 2025 at 00:14, Joel Granados <joel.granados@...nel.org> wrote:
>
>   All ctl_table declared outside of functions and that remain unmodified after
>   initialization are const qualified.

Hmm. A quick grep shows

    static struct ctl_table alignment_tbl[5] = {

in arch/csky/abiv1/alignment.c that didn't get converted.

And a couple of rdma drivers (iwcm_ctl_table and ucma_ctl_table), but
maybe those weren't converted due to being in the "net" address space?

Anyway, taken as-is, I'm just noting the lacking cases.

            Linus