linux-hardening - Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5tkaaMNh83x2t/x@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date: Thu, 30 Jan 2025 12:37:13 +0100
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Halil Pasic <pasic@...ux.ibm.com>
Cc: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Thorsten Blum <thorsten.blum@...ux.dev>,
        Tony Krowiak <akrowiak@...ux.ibm.com>,
        Jason Herne <jjherne@...ux.ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Holger Dengler <dengler@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-hardening@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible
 array member

On Thu, Jan 30, 2025 at 11:46:15AM +0100, Halil Pasic wrote:
> > > I'm not sure I understand the value of this. What we have here is not
> > > a flexible array but a one element array. Something that in the generic
> > > case could be many but particularly for vfio-ap is always one.  
> > 
> > You are correct. Only fake flexible arrays should be transformed into
> > C99 flex-array members [1].
> > 
> > Thanks
> > -Gustavo
> > 
> > [1] https://lwn.net/Articles/908817/
> > 
> 
> Thanks! Alex, what do we do with this then? I think you picked it up
> yesterday late. And I think, it might make sense to make this look
> less like a fake flex-array...

Dropped.
Thanks for looking into it!