linux-hardening - Re: [PATCH][next] tty: tty_buffer: Avoid hundreds of -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec807b7f-70af-4f27-8c88-6844020bd850@embeddedor.com>
Date: Wed, 5 Feb 2025 18:55:35 +1030
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] tty: tty_buffer: Avoid hundreds of
 -Wflex-array-member-not-at-end warnings


> 
>> The problem with this is that then we have to modify a lot of
>> lines from, let's say, instance->used, instance->size, etc...
>> to instance->hdr.used, instance->hdr.size, and so on...
> 
> Great, let's do that and get it right please.

Deal!

> 
>> This code churn is avoided if we use the struct_group() helper.
> 
> It's not "churn" if it is "fix the code to be correct" :)

As long as those warnings are fixed and we harden the kernel, I'm
really okay with whatever maintainers prefer. :)

Thanks!
-Gustavo