linux-hardening - Re: [PATCH v2] scsi: hpsa: Replace deprecated strncpy() with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c1fcd13-ffac-4590-a345-c5389d1ccc9f@acm.org>
Date: Thu, 13 Feb 2025 10:24:25 -0800
From: Bart Van Assche <bvanassche@....org>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Don Brace <don.brace@...rochip.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-hardening@...r.kernel.org, storagedev@...rochip.com,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: hpsa: Replace deprecated strncpy() with
 strscpy_pad()

On 2/13/25 3:40 AM, Thorsten Blum wrote:
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index c7ebae24b09f..968cefb497eb 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -7236,8 +7236,7 @@ static int hpsa_controller_hard_reset(struct pci_dev *pdev,
>   
>   static void init_driver_version(char *driver_version, int len)
>   {
> -	memset(driver_version, 0, len);
> -	strncpy(driver_version, HPSA " " HPSA_DRIVER_VERSION, len - 1);
> +	strscpy_pad(driver_version, HPSA " " HPSA_DRIVER_VERSION, len);
>   }
>   
>   static int write_driver_ver_to_cfgtable(struct CfgTable __iomem *cfgtable)

Has it been considered to introduce a Coccinelle semantic patch that
performs this conversion? See also the scripts/coccinelle directory.

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>