linux-hardening - Re: [PATCH 00/10] lib/string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdX-ZMf-mYrnA=DYszK8KvjVfi0kz30WfHRN_oYOJR_Hw@mail.gmail.com>
Date: Mon, 3 Mar 2025 08:20:20 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: Kees Cook <kees@...nel.org>, Andy Shevchenko <andy@...nel.org>, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 00/10] lib/string_choices: Add new helpers

On Mon, Mar 3, 2025 at 1:16 AM Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
>
>
> Hi Kees
>
> Thank you for your feedback
>
> > > I would like to use string_choices helper to cleanup the code, but it missing
> > > some of well used string pair in kernel. This patch-set adds it.
> >
> > Do you have some Coccinelle scripts or other patches that show the use
> > of these helpers? We tend to avoid adding new helpers to the kernel
> > unless there are active uses of them.
>
> I have a lot of patches which uses new helper functions.
> Because it has dependency (add new helper 1st, use it in 2nd), and
> different maintainers (helper patch maintainers vs each driver/framwork
> maintainers), I have posted new helper patch-set 1st (= this patch-set).
> After that, I will post 2nd patch-set which uses new helper, like
> new helper patch for v6.15, each driver/framework patch for v6.16, etc.
>
> Because there are a lot of patches which uses new helpers, is it OK to
> indicates some of them (as sample patch) ?

I am not Kees, but my point of view on this is that you may take one
subsystem which, for example, I can review (listed as a Designated
Reviewer or Maintainer in the MAINTAINERS) and add sample patches from
it. It will speed up the process as my tag would suffice. Also you can
add into the cover letter the statistics (how many drivers are
affected (per subsystem/folder) by each of the new helpers in the
upcoming series.

-- 
With Best Regards,
Andy Shevchenko