lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <87v7sppmqu.wl-kuninori.morimoto.gx@renesas.com>
Date: Tue, 4 Mar 2025 02:12:41 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Andy Shevchenko <andy@...nel.org>, Kees Cook <kees@...nel.org>, linux-hardening@...r.kernel.org
Subject: [PATCH v2 00/10] lib/string_choices: Add new helpers


Hi Kees, Andy

This is v2 patch-set of "add new helpers".
I would like to use string_choices helper to cleanup the code, but it is
missing some of well used string pair in kernel. This patch-set adds it.

Step1
	Add new helpers (This patch-set)
Step2
	Each driver/framework use new helper

You can see "git diff --stat" of Step2 on last of this mail.
One note is that it is including the patch which is using only existing
helper (= not using new helper).
I added sample patch of Step2 in this patch-set as [SAMPLE].

One concern is that it adds "pass/fail", but we can find many similar
strings, like below. I have choiced "pass/fail" and use it on all cases
in my local branch (You can see some of them in [SAMPLE].
I need your opinion

	passed     / failed
	succeed    / failed
	success    / failed
	successful / failed
	succeeded  / failed
	worked     / failed

v1 -> v2
	- add Cc to Andy
	- add [SAMPLE] patches

Kuninori Morimoto (10):
  lib/string_choices: Add str_tx_rx() helper
  lib/string_choices: Add str_enabling_disabling() helper
  lib/string_choices: Add str_in_out() helper
  lib/string_choices: Add str_input_output() helper
  lib/string_choices: Add str_Y_N() helper
  lib/string_choices: Add str_pass_fail() helper
  lib/string_choices: Add str_to_from() helper
  lib/string_choices: Add str_level_edge() helper
  lib/string_choices: Add str_kernel_user() helper
  lib/string_choices: Add str_attach_detach() helper

 include/linux/string_choices.h | 61 ++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

------ diff --stat of Step2 -------
 arch/alpha/kernel/core_cia.c                       |  4 +-
 arch/alpha/kernel/core_tsunami.c                   |  5 +--
 arch/arm/kernel/bios32.c                           |  5 ++-
 arch/arm/mach-omap1/board-ams-delta.c              |  4 +-
 arch/arm/mach-omap2/board-n8x0.c                   |  2 +-
 arch/arm/mach-orion5x/ts78xx-setup.c               |  2 +-
 arch/arm/mach-s3c/pm.c                             |  2 +-
 arch/arm/mm/cache-l2x0.c                           |  7 ++--
 arch/arm/mm/cache-tauros2.c                        |  7 ++--
 arch/arm/mm/fault.c                                |  2 +-
 arch/arm/mm/pmsa-v7.c                              |  2 +-
 arch/arm/plat-orion/gpio.c                         |  6 +--
 arch/arm64/kernel/cpufeature.c                     |  2 +-
 arch/arm64/kernel/reloc_test_core.c                |  3 +-
 arch/arm64/kvm/sys_regs.c                          |  2 +-
 arch/arm64/kvm/sys_regs.h                          |  2 +-
 arch/arm64/kvm/trace_arm.h                         |  6 +--
 arch/arm64/kvm/trace_handle_exit.h                 |  2 +-
 arch/m68k/sun3/mmu_emu.c                           |  2 +-
 arch/microblaze/kernel/exceptions.c                |  4 +-
 arch/mips/jazz/jazzdma.c                           |  2 +-
 arch/mips/kernel/mips-cm.c                         |  5 ++-
 arch/mips/mm/fault.c                               |  5 ++-
 arch/mips/pci/pci-octeon.c                         |  3 +-
 arch/nios2/kernel/traps.c                          |  2 +-
 arch/powerpc/kernel/fadump.c                       |  6 +--
 arch/powerpc/kernel/iommu.c                        |  2 +-
 arch/powerpc/kernel/kvm.c                          |  5 ++-
 arch/powerpc/kernel/prom_init.c                    |  3 +-
 arch/powerpc/mm/fault.c                            |  6 +--
 arch/powerpc/platforms/85xx/ge_imp3a.c             |  3 +-
 arch/powerpc/platforms/86xx/gef_ppc9a.c            |  3 +-
 arch/powerpc/platforms/cell/iommu.c                |  3 +-
 arch/powerpc/platforms/powermac/setup.c            |  3 +-
 arch/powerpc/platforms/powermac/time.c             |  3 +-
 arch/powerpc/platforms/powernv/eeh-powernv.c       |  4 +-
 arch/powerpc/platforms/powernv/pci-ioda.c          |  2 +-
 arch/powerpc/platforms/powernv/pci-sriov.c         |  5 ++-
 arch/powerpc/platforms/powernv/vas.h               |  3 +-
 arch/powerpc/platforms/ps3/device-init.c           |  2 +-
 arch/powerpc/sysdev/mpic.c                         |  3 +-
 arch/powerpc/sysdev/xive/common.c                  |  4 +-
 arch/s390/kernel/dis.c                             |  3 +-
 arch/s390/kernel/dumpstack.c                       |  5 ++-
 arch/s390/kvm/trace-s390.h                         |  2 +-
 arch/um/drivers/virtio_uml.c                       |  3 +-
 arch/um/kernel/um_arch.c                           |  2 +-
 arch/x86/kernel/apic/io_apic.c                     |  6 +--
 arch/x86/kernel/apic/ipi.c                         |  3 +-
 arch/x86/kernel/cet.c                              |  4 +-
 arch/x86/kernel/cpu/mtrr/generic.c                 | 12 +++---
 arch/x86/kvm/trace.h                               | 24 +++++------
 arch/x86/platform/intel-quark/imr.c                |  2 +-
 arch/x86/platform/uv/uv_nmi.c                      |  2 +-
 crypto/aead.c                                      |  3 +-
 crypto/ahash.c                                     |  3 +-
 crypto/async_tx/raid6test.c                        |  3 +-
 crypto/skcipher.c                                  |  3 +-
 drivers/accel/habanalabs/common/firmware_if.c      | 13 +++---
 drivers/accel/habanalabs/gaudi/gaudi.c             | 12 +++---
 drivers/accel/habanalabs/gaudi/gaudi_coresight.c   |  8 ++--
 drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c |  8 ++--
 drivers/accel/habanalabs/goya/goya.c               |  8 ++--
 drivers/accel/habanalabs/goya/goya_coresight.c     |  8 ++--
 drivers/accel/ivpu/ivpu_hw_btrs.c                  |  3 +-
 drivers/acpi/acpi_video.c                          |  6 +--
 drivers/acpi/numa/srat.c                           | 22 ++++-------
 drivers/acpi/pci_irq.c                             |  5 ++-
 drivers/acpi/power.c                               |  5 ++-
 drivers/acpi/proc.c                                |  8 ++--
 drivers/acpi/resource.c                            |  5 ++-
 drivers/acpi/sbs.c                                 |  5 ++-
 drivers/acpi/x86/s2idle.c                          |  6 +--
 drivers/android/binder.c                           |  2 +-
 drivers/ata/pata_arasan_cf.c                       |  2 +-
 drivers/ata/pata_ixp4xx_cf.c                       |  2 +-
 drivers/ata/sata_via.c                             |  2 +-
 drivers/atm/fore200e.c                             |  2 +-
 drivers/atm/nicstar.c                              |  2 +-
 drivers/base/physical_location.c                   |  7 ++--
 drivers/block/amiflop.c                            |  2 +-
 drivers/block/aoe/aoeblk.c                         |  2 +-
 drivers/block/drbd/drbd_actlog.c                   |  6 +--
 drivers/block/drbd/drbd_req.c                      |  2 +-
 drivers/block/mtip32xx/mtip32xx.c                  |  3 +-
 drivers/block/nbd.c                                |  2 +-
 drivers/block/ps3disk.c                            |  5 ++-
 drivers/block/ps3vram.c                            |  2 +-
 drivers/block/rnbd/rnbd-clt.c                      |  2 +-
 drivers/block/xen-blkback/blkback.c                |  3 +-
 drivers/block/xen-blkfront.c                       | 10 ++---
 drivers/bluetooth/bt3c_cs.c                        |  2 +-
 drivers/bluetooth/btmrvl_main.c                    | 10 ++---
 drivers/bluetooth/hci_bcm.c                        |  2 +-
 drivers/bluetooth/hci_ldisc.c                      | 12 +++---
 drivers/bus/intel-ixp4xx-eb.c                      |  3 +-
 drivers/bus/mhi/host/debugfs.c                     |  2 +-
 drivers/bus/uniphier-system-bus.c                  |  3 +-
 drivers/cdrom/cdrom.c                              |  3 +-
 drivers/char/hpet.c                                |  4 +-
 drivers/char/ps3flash.c                            |  3 +-
 drivers/char/sonypi.c                              | 10 ++---
 drivers/char/virtio_console.c                      |  3 +-
 drivers/clk/clk-nomadik.c                          |  6 +--
 drivers/clk/clk-xgene.c                            |  2 +-
 drivers/clk/renesas/renesas-cpg-mssr.c             |  3 +-
 drivers/clk/renesas/rzg2l-cpg.c                    |  4 +-
 drivers/clk/renesas/rzv2h-cpg.c                    |  4 +-
 drivers/counter/stm32-timer-cnt.c                  |  6 ++-
 drivers/cpufreq/amd-pstate-trace.h                 |  3 +-
 drivers/cpufreq/cpufreq.c                          |  2 +-
 drivers/cpuidle/sysfs.c                            |  4 +-
 drivers/crypto/bcm/cipher.c                        |  2 +-
 drivers/crypto/bcm/spu2.c                          |  3 +-
 drivers/crypto/caam/caamalg_qi2.c                  |  2 +-
 drivers/crypto/intel/qat/qat_common/adf_sysfs.c    |  9 +++--
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c  |  4 +-
 .../crypto/marvell/octeontx2/otx2_cptpf_ucode.c    |  2 +-
 drivers/crypto/nx/nx-common-powernv.c              |  7 ++--
 drivers/crypto/nx/nx-common-pseries.c              |  9 +++--
 drivers/cxl/core/hdm.c                             |  2 +-
 drivers/cxl/core/port.c                            |  2 +-
 drivers/dax/device.c                               |  3 +-
 drivers/dma-buf/st-dma-fence.c                     |  3 +-
 drivers/dma/amba-pl08x.c                           |  2 +-
 drivers/dma/at_hdmac.c                             |  8 ++--
 drivers/dma/at_xdmac.c                             |  4 +-
 drivers/dma/dw-edma/dw-edma-core.c                 |  4 +-
 drivers/dma/imx-dma.c                              |  2 +-
 drivers/dma/ppc4xx/adma.c                          |  4 +-
 drivers/dma/pxa_dma.c                              |  3 +-
 drivers/dma/sh/rcar-dmac.c                         |  4 +-
 drivers/dma/ste_dma40.c                            |  2 +-
 drivers/dma/sun6i-dma.c                            |  2 +-
 drivers/dma/ti/edma.c                              |  2 +-
 drivers/dma/xilinx/xilinx_dma.c                    |  2 +-
 drivers/edac/amd64_edac.c                          | 46 +++++++++++-----------
 drivers/edac/i5000_edac.c                          |  2 +-
 drivers/edac/i5400_edac.c                          |  2 +-
 drivers/edac/i7300_edac.c                          |  6 +--
 drivers/edac/i82975x_edac.c                        | 10 ++---
 drivers/edac/xgene_edac.c                          | 16 ++++----
 drivers/extcon/extcon-max14577.c                   | 32 +++++++--------
 drivers/extcon/extcon-max77693.c                   | 44 ++++++++++-----------
 drivers/extcon/extcon-max77843.c                   | 40 +++++++++----------
 drivers/extcon/extcon-max8997.c                    | 24 +++++------
 drivers/extcon/extcon-rtk-type-c.c                 |  6 +--
 drivers/firmware/arm_scmi/driver.c                 |  2 +-
 drivers/firmware/arm_scmi/shmem.c                  |  3 +-
 drivers/firmware/arm_scmi/transports/mailbox.c     |  3 +-
 drivers/firmware/arm_scmi/transports/virtio.c      |  3 +-
 drivers/firmware/cirrus/cs_dsp.c                   |  2 +-
 drivers/firmware/efi/cper-x86.c                    |  2 +-
 drivers/firmware/efi/libstub/arm32-stub.c          |  4 +-
 drivers/fpga/altera-fpga2sdram.c                   |  3 +-
 drivers/fpga/altera-hps2fpga.c                     |  3 +-
 drivers/fpga/fpga-bridge.c                         |  3 +-
 drivers/fsi/fsi-core.c                             |  3 +-
 drivers/fsi/fsi-master-ast-cf.c                    |  3 +-
 drivers/fsi/fsi-sbefifo.c                          |  5 ++-
 drivers/gpio/gpio-brcmstb.c                        |  3 +-
 drivers/gpio/gpio-crystalcove.c                    |  7 ++--
 drivers/gpio/gpio-grgpio.c                         |  3 +-
 drivers/gpio/gpio-mvebu.c                          |  6 +--
 drivers/gpio/gpio-nomadik.c                        |  2 +-
 drivers/gpio/gpio-pl061.c                          |  3 +-
 drivers/gpio/gpio-stmpe.c                          |  8 ++--
 drivers/gpio/gpio-virtuser.c                       |  2 +-
 drivers/gpio/gpio-wcove.c                          |  7 ++--
 drivers/gpio/gpio-wm831x.c                         |  4 +-
 drivers/gpio/gpio-xra1403.c                        |  4 +-
 drivers/gpio/gpiolib-sysfs.c                       |  3 +-
 drivers/gpio/gpiolib.c                             | 15 +++----
 drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c           |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c         |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c           |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c             |  4 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c             |  4 +-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c              |  4 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c              |  4 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c              |  3 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c              |  5 +--
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c              |  5 +--
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c              |  5 +--
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c               |  2 +-
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  7 ++--
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c |  4 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c  |  4 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c  |  8 ++--
 drivers/gpu/drm/amd/display/dc/core/dc.c           |  2 +-
 .../drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c    |  2 +-
 drivers/gpu/drm/amd/pm/amdgpu_dpm.c                | 10 ++---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c                 |  2 +-
 drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c         |  4 +-
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c  |  2 +-
 drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c     | 10 ++---
 drivers/i2c/busses/i2c-exynos5.c                   |  2 +-
 drivers/i2c/busses/i2c-hix5hd2.c                   |  2 +-
 drivers/i2c/busses/i2c-rcar.c                      |  3 +-
 drivers/i2c/busses/i2c-sh_mobile.c                 |  3 +-
 drivers/mailbox/ti-msgmgr.c                        |  5 ++-
 drivers/mmc/host/pxamci.c                          |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_enet.c      |  2 +-
 drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c |  3 +-
 drivers/net/ethernet/huawei/hinic/hinic_ethtool.c  |  2 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c       |  2 +-
 drivers/net/ethernet/qlogic/qede/qede_ethtool.c    |  3 +-
 drivers/net/ethernet/ti/cpsw_ethtool.c             |  6 +--
 drivers/net/wireless/ath/ath10k/usb.c              | 15 +++----
 drivers/net/wireless/ath/ath6kl/trace.h            |  4 +-
 drivers/net/wireless/ath/ath9k/mci.c               |  3 +-
 drivers/rpmsg/qcom_glink_trace.h                   | 26 ++++++------
 drivers/scsi/qla2xxx/qla_edif.c                    |  3 +-
 drivers/spi/spi-rspi.c                             |  3 +-
 drivers/spi/spi-s3c64xx.c                          |  3 +-
 drivers/spi/spi-sh-msiof.c                         |  4 +-
 drivers/spi/spi-tegra114.c                         |  3 +-
 drivers/spi/spi-tegra20-slink.c                    |  3 +-
 drivers/tty/serial/serial-tegra.c                  |  2 +-
 drivers/tty/serial/sh-sci.c                        |  2 +-
 drivers/usb/atm/usbatm.c                           |  2 +-
 drivers/usb/gadget/udc/bcm63xx_udc.c               |  8 ++--
 drivers/usb/musb/musb_trace.h                      |  2 +-
 drivers/usb/musb/tusb6010_omap.c                   | 14 +++----
 include/trace/events/afs.h                         |  4 +-
 sound/core/ump.c                                   |  7 ++--
 sound/drivers/vx/vx_core.c                         |  2 +-
 sound/pci/rme9652/hdspm.c                          |  3 +-
 sound/soc/codecs/tas2781-i2c.c                     |  4 +-
 sound/soc/codecs/tlv320dac33.c                     |  2 +-
 sound/soc/fsl/fsl_asrc_dma.c                       |  2 +-
 sound/soc/pxa/pxa-ssp.c                            |  3 +-
 sound/soc/renesas/fsi.c                            |  2 +-
 sound/soc/renesas/rcar/dma.c                       |  2 +-
 sound/soc/renesas/rcar/rsnd.h                      |  3 +-
 sound/soc/renesas/rcar/src.c                       |  3 +-
 sound/soc/renesas/rcar/ssiu.c                      |  6 +--
 sound/soc/rockchip/rockchip_i2s_tdm.c              |  2 +-
 sound/soc/soc-core.c                               |  2 +-
 sound/soc/soc-dapm.c                               |  2 +-
 sound/usb/proc.c                                   |  2 +-
 244 files changed, 604 insertions(+), 602 deletions(-)


-- 
2.43.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ