linux-hardening - Re: [PATCH v2 00/10] lib/string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmd4z762.wl-kuninori.morimoto.gx@renesas.com>
Date: Tue, 4 Mar 2025 23:51:17 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Kees Cook <kees@...nel.org>
Cc: Andy Shevchenko <andy@...nel.org>,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 00/10] lib/string_choices: Add new helpers


Hi Kees, Andy

Thank you for your feedbacks

> That said, I would expect the series out of 3/4 patches
> 1) add str_in_out() and/or str_input_output();
> 2) use it in gpio-crystalcove.c
> 3) use it in gpio-wcove.c
>
> This can be easily combined into an immutable tag/branch and pulled by
> the affected subsystems. With your lengthy series it will be ages to
> get it in.
(snip)
> str_in_out.patch:              66 files changed, 130 insertions(+), 136 deletions(-)
> str_tx_rx.patch:               33 files changed, 48 insertions(+), 53 deletions(-)
> str_input_output.patch:        17 files changed, 27 insertions(+), 29 deletions(-)
> str_enabling_disabling.patch:  16 files changed, 25 insertions(+), 25 deletions(-)
> str_Y_N.patch:                 13 files changed, 98 insertions(+), 89 deletions(-)
> str_kernel_user.patch:          7 files changed, 8 insertions(+), 7 deletions(-)
> str_level_edge.patch:           5 files changed, 6 insertions(+), 6 deletions(-)
> str_to_from.patch:              3 files changed, 4 insertions(+), 4 deletions(-)
> str_pass_fail.patch:            2 files changed, 2 insertions(+), 2 deletions(-)
> str_attach_detach.patch:        1 file changed, 4 insertions(+), 4 deletions(-)
> 
> So, IMO, the first 5 are clear winners. The others are probably fine,
> but pass/fail and attach/detach are really not used much.

Thanks.
My plan was add new helper 1st, and use helper (both new and exists) 2nd
on each driver/framwork. But indeed it is not so good from reviewer point
of view. And (aside from the "success/failed" topic) indeed some of new
helper are not good/needed.

I will try to post v3 patch, but want to cleanup before that.
v3 will be above top 5 helpers only.

Thank you for your help !!

Best regards
---
Kuninori Morimoto