linux-hardening - Re: [PATCH] ALSA: ctxfi: change dao_set_input functions from kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plipyyaz.wl-tiwai@suse.de>
Date: Mon, 10 Mar 2025 11:28:36 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Ethan Carter Edwards <ethan@...ancedwards.com>
Cc: Takashi Iwai <tiwai@...e.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: change dao_set_input functions from kzalloc to kcalloc

On Sat, 08 Mar 2025 19:52:59 +0100,
Ethan Carter Edwards wrote:
> 
> We are trying to get rid of all multiplications from allocation
> functions to prevent potential integer overflows. Here the
> multiplication is probably safe, but using kcalloc() is more
> appropriate and improves readability. This patch has no effect
> on runtime behavior.
> 
> Link: https://github.com/KSPP/linux/issues/162 [1]
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> 
> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>

Thanks, applied now.


Takashi