linux-hardening - Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for unterminated strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c02e66a7-903c-43c1-8b8a-81ef5084d719@leemhuis.info>
Date: Tue, 1 Apr 2025 11:28:23 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Jani Nikula <jani.nikula@...ux.intel.com>, Kees Cook <kees@...nel.org>,
 Zhenyu Wang <zhenyuw@...ux.intel.com>
Cc: Zhi Wang <zhi.wang.linux@...il.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin
 <tursulin@...ulin.net>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, intel-gvt-dev@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
 Justin Forbes <jforbes@...hat.com>, Nicolas Chauvet <kwizart@...il.com>
Subject: Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for
 unterminated strings

On 01.04.25 10:46, Jani Nikula wrote:
> On Mon, 31 Mar 2025, Thorsten Leemhuis <linux@...mhuis.info> wrote:
>> On 10.03.25 23:23, Kees Cook wrote:
>>> When a character array without a terminating NUL character has a static
>>> initializer, GCC 15's -Wunterminated-string-initialization will only
>>> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
>>> with __nonstring to and correctly identify the char array as "not a C
>>> string" and thereby eliminate the warning.
>>>
>>> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
>>> [...]
>>> Signed-off-by: Kees Cook <kees@...nel.org>
>>
>> To provide another small data point:
>>
>> Tested-by: Thorsten Leemhuis <linux@...mhuis.info>
>>
>> A "Compile-Tested-by", to be precise: after a handful similar patches
>> reached mainline recently this is the only one I still need to compile
>> the pretty broad Fedora rawhide config on rawhide using the GCC 15
>> pre-release it currently includes. The latter or the final will
>> hopefully soon also reach Fedora 42 beta as well and bring the "[1]"
>> mentioned in the patch description above to F42 -- which will be
>> released in a few weeks, so I guess it would be nice to have this patch
>> mainlined rather sooner that later to avoid more people running into this.
> 
> Thanks for testing, though I've merged [1] instead.
> 
> [1] https://lore.kernel.org/r/20250327124739.2609656-1-jani.nikula@intel.com

Yeah, sorry, I only spotted that one two hours ago and started a test
compile a while ago, but seems I'm too late here. Whatever, happens. :-D

Many thx for taking care of that! Ciao, Thorsten