linux-hardening - Re: [PATCH v11 nf-next 0/2] Add nf_flow_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_VIpa9SP05rsW18@calendula>
Date: Tue, 8 Apr 2025 18:02:45 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Michal Ostrowski <mostrows@...thlink.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Simon Horman <horms@...nel.org>,
	Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v11 nf-next 0/2] Add nf_flow_encap_push() for xmit direct

Hi,

Please, one series at a time. You pick a good target to start with.

I already provided a few suggestions on where to start from.

Thanks.

On Tue, Apr 08, 2025 at 04:24:23PM +0200, Eric Woudstra wrote:
> Patch to add nf_flow_encap_push(), see patch message.
> 
> Added patch to eliminate array of flexible structures warning.
> 
> Changed in v11:
> - Only push when tuple.out.ifidx == tuple.out.hw_ifidx
> - No changes in nft_dev_path_info()
> 
> v10 split from patch-set: bridge-fastpath and related improvements v9
> 
> Eric Woudstra (2):
>   net: pppoe: avoid zero-length arrays in struct pppoe_hdr
>   netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit
>     direct
> 
>  drivers/net/ppp/pppoe.c          |  2 +-
>  include/uapi/linux/if_pppox.h    |  4 ++
>  net/netfilter/nf_flow_table_ip.c | 97 +++++++++++++++++++++++++++++++-
>  3 files changed, 100 insertions(+), 3 deletions(-)
> 
> -- 
> 2.47.1
>