linux-hardening - Re: [PATCH] gcc-plugins: Remove SANCOV plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504090919.6DE21CFA7A@keescook>
Date: Wed, 9 Apr 2025 09:19:57 -0700
From: Kees Cook <kees@...nel.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Andrey Konovalov <andreyknvl@...il.com>,
	linux-kbuild@...r.kernel.org, linux-hardening@...r.kernel.org,
	kasan-dev@...glegroups.com, Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH] gcc-plugins: Remove SANCOV plugin

On Wed, Apr 09, 2025 at 06:16:58PM +0200, Arnd Bergmann wrote:
> On Wed, Apr 9, 2025, at 18:02, Kees Cook wrote:
> > There are very few users of this plugin[1], and since it's features
> > are available in GCC 6 and later (and Clang), users can update their
> > compilers if they need support on newer kernels.
> >
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> > Link: 
> > https://lore.kernel.org/all/08393aa3-05a3-4e3f-8004-f374a3ec4b7e@app.fastmail.com/ 
> > [1]
> > Signed-off-by: Kees Cook <kees@...nel.org>
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 1af972a92d06..e7347419ffc5 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -2135,15 +2135,13 @@ config ARCH_HAS_KCOV
> >  config CC_HAS_SANCOV_TRACE_PC
> >  	def_bool $(cc-option,-fsanitize-coverage=trace-pc)
> > 
> 
> My version removed CC_HAS_SANCOV_TRACE_PC as well, as I planned
> to have this on top of my patch to require gcc-8.1 as the
> minimum version.
> 
> >  config KCOV
> >  	bool "Code coverage for fuzzing"
> >  	depends on ARCH_HAS_KCOV
> > -	depends on CC_HAS_SANCOV_TRACE_PC || GCC_PLUGINS
> > +	depends on CC_HAS_SANCOV_TRACE_PC
> 
> So this dependency would also disappear. I think either way is fine.
> 
> The rest of the patch is again identical to my version.

Ah! How about you keep the patch as part of your gcc-8.1 clean up, then?
That seems more clear, etc.

-Kees

-- 
Kees Cook