linux-hardening - Re: [PATCH v2 03/14] mfd: Add Microchip ZL3073x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eecfb843-e9cd-4d07-bb72-15cf84a25706@kernel.org>
Date: Thu, 10 Apr 2025 09:19:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andy@...nel.org>, Ivan Vecera <ivecera@...hat.com>
Cc: netdev@...r.kernel.org, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jiri Pirko <jiri@...nulli.us>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Lee Jones <lee@...nel.org>, Kees Cook <kees@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Michal Schmidt <mschmidt@...hat.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 03/14] mfd: Add Microchip ZL3073x support

On 09/04/2025 17:43, Andy Shevchenko wrote:
>> +/*
>> + * Regmap range configuration
>> + *
>> + * The device uses 7-bit addressing and has 16 register pages with
>> + * range 0x00-0x7f. The register 0x7f in each page acts as page
>> + * selector where bits 0-3 contains currently selected page.
>> + */
>> +static const struct regmap_range_cfg zl3073x_regmap_ranges[] = {
>> +	{
>> +		.range_min	= 0,
> 
> This still has the same issue, you haven't given a chance to me to reply
> in v1 thread. I'm not going to review this as it's not settled down yet.
> Let's first discuss the questions you have in v1.
> 
I already started reviewing v2, so now we have simultaneous discussions
in v1 and v2...

Best regards,
Krzysztof