linux-hardening - Re: [PATCH] md/bcache: Mark _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <24407A22-09EF-4A40-A624-181EBC28D35B@coly.li>
Date: Thu, 17 Apr 2025 12:13:12 +0800
From: Coly Li <i@...y.li>
To: Kees Cook <kees@...nel.org>
Cc: Coly Li <colyli@...nel.org>,
 Kent Overstreet <kent.overstreet@...ux.dev>,
 linux-bcache@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] md/bcache: Mark __nonstring look-up table



> 2025年4月17日 06:01，Kees Cook <kees@...nel.org> 写道：
> 
> GCC 15's new -Wunterminated-string-initialization notices that the 16
> character lookup table "zero_uuid" (which is not used as a C-String)
> needs to be marked as "nonstring":
> 
> drivers/md/bcache/super.c: In function 'uuid_find_empty':
> drivers/md/bcache/super.c:549:43: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (17 chars into 16 available) [-Wunterminated-string-initialization]
>  549 |         static const char zero_uuid[16] = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
>      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add the annotation to silence the GCC warning.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Coly Li <colyli@...nel.org>
> Cc: Kent Overstreet <kent.overstreet@...ux.dev>
> Cc: linux-bcache@...r.kernel.org <mailto:linux-bcache@...r.kernel.org>   

It looks good to me. Thanks for the fix up.


Coly Li



> ---
> drivers/md/bcache/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index e42f1400cea9..577d048170fe 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -546,7 +546,7 @@ static struct uuid_entry *uuid_find(struct cache_set *c, const char *uuid)
> 
> static struct uuid_entry *uuid_find_empty(struct cache_set *c)
> {
> - static const char zero_uuid[16] = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
> + static const char zero_uuid[] __nonstring = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
> 
> return uuid_find(c, zero_uuid);
> }
> -- 
> 2.34.1
> 
>