linux-hardening - [PATCH v2] rcuscale: using kcalloc() to relpace kmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250422015144.2012708-1-suhui@nfschina.com>
Date: Tue, 22 Apr 2025 09:51:45 +0800
From: Su Hui <suhui@...china.com>
To: dave@...olabs.net,
	paulmck@...nel.org,
	josh@...htriplett.org,
	frederic@...nel.org,
	neeraj.upadhyay@...nel.org,
	joel@...lfernandes.org,
	boqun.feng@...il.com,
	urezki@...il.com,
	rostedt@...dmis.org,
	mathieu.desnoyers@...icios.com,
	jiangshanlai@...il.com,
	qiang.zhang1211@...il.com
Cc: Su Hui <suhui@...china.com>,
	linux-kernel@...r.kernel.org,
	rcu@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH v2] rcuscale: using kcalloc() to relpace kmalloc()

It's safer to using kcalloc() because it can prevent overflow
problem.

Signed-off-by: Su Hui <suhui@...china.com>
---
v2: 
 - using kcalloc rather than kmalloc_array().
v1:
 - https://lore.kernel.org/all/20250421061508.718752-1-suhui@nfschina.com/

 kernel/rcu/rcuscale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index 0f3059b1b80d..b521d0455992 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -762,7 +762,7 @@ kfree_scale_thread(void *arg)
 		}
 
 		for (i = 0; i < kfree_alloc_num; i++) {
-			alloc_ptr = kmalloc(kfree_mult * sizeof(struct kfree_obj), GFP_KERNEL);
+			alloc_ptr = kcalloc(kfree_mult, sizeof(struct kfree_obj), GFP_KERNEL);
 			if (!alloc_ptr)
 				return -ENOMEM;
 
-- 
2.30.2