linux-hardening - Re: [PATCH] drm/i915/gt: Remove const from struct i915

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504301356.CB1EEC719@keescook>
Date: Wed, 30 Apr 2025 13:56:51 -0700
From: Kees Cook <kees@...nel.org>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Matt Roper <matthew.d.roper@...el.com>,
	Gustavo Sousa <gustavo.sousa@...el.com>,
	Andi Shyti <andi.shyti@...ux.intel.com>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	Gnattu OC <gnattuoc@...com>, Nitin Gote <nitin.r.gote@...el.com>,
	Ranu Maurya <ranu.maurya@...el.com>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	Angus Chen <angus.chen@...el.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@...il.com>,
	Yu Jiaoliang <yujiaoliang@...o.com>,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@...el.com>,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] drm/i915/gt: Remove const from struct i915_wa list
 allocation

On Mon, Apr 28, 2025 at 02:40:16PM +0300, Jani Nikula wrote:
> On Fri, 25 Apr 2025, Kees Cook <kees@...nel.org> wrote:
> > In preparation for making the kmalloc family of allocators type aware,
> > we need to make sure that the returned type from the allocation matches
> > the type of the variable being assigned. (Before, the allocator would
> > always return "void *", which can be implicitly cast to any pointer type.)
> >
> > The assigned type is "struct i915_wa *". The returned type, while
> > technically matching, will be const qualified. As there is no general
> > way to remove const qualifiers, adjust the allocation type to match
> > the assignment.
> >
> > Signed-off-by: Kees Cook <kees@...nel.org>
> 
> Acked-by: Jani Nikula <jani.nikula@...el.com>
> 
> for merging via whichever tree you find best; please let us know if you
> want us to pick this up via drm-intel.

I was figuring each subsystem would want these individually, so please
take this via drm-intel. (Or I can take it if you'd rather not.)

Thanks!

-Kees

-- 
Kees Cook