linux-hardening - Re: [PATCH v2][next] scsi: sd: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33d7a1b3-4bf7-4337-ba82-dbd4b95ad0b8@acm.org>
Date: Sat, 3 May 2025 12:08:23 -0700
From: Bart Van Assche <bvanassche@....org>
To: Christoph Hellwig <hch@...radead.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2][next] scsi: sd: Avoid -Wflex-array-member-not-at-end
 warning

On 5/1/25 11:50 PM, Christoph Hellwig wrote:
> (I still wish we'd kill the stupid struct and this test and just used
> the simpler and cleaner bitshifting and masking)

Bit-shifting and masking results in faster code. For slow path code I
prefer bitfields because this results in much more compact source code.

Bart.