linux-hardening - Re: [PATCH v4 05/11] firmware: qcom: scm: add support for object invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCWFZchX9nbZOC89@sumit-X1>
Date: Thu, 15 May 2025 11:40:45 +0530
From: Sumit Garg <sumit.garg@...nel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Cc: Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Apurupa Pattapu <quic_apurupa@...cinc.com>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Christian König <christian.koenig@....com>,
	linux-arm-msm@...r.kernel.org, op-tee@...ts.trustedfirmware.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 05/11] firmware: qcom: scm: add support for object
 invocation

On Wed, May 14, 2025 at 05:27:44PM +0200, Bartosz Golaszewski wrote:
> On Wed, 14 May 2025 at 11:37, Sumit Garg <sumit.garg@...nel.org> wrote:
> >
> > Hi Amir,
> >
> > I am still unable to get the QCOMTEE driver to work on db845c. As I can
> > see machine: "qcom,sdm845" is not supported for tzmem based on SHM
> > brigde here: drivers/firmware/qcom/qcom_tzmem.c +81. I am still seeing
> > following logs from userspace:
> >
> > # /mnt/unittest -d
> > [test_print_diagnostics_info][31] test_get_client_env_object.
> > [test_supplicant_release][65] test_supplicant_worker killed.
> >
> > I think you should first check here for SHM bridge support. If available
> > then only add a QTEE platform device.
> >
> 
> On platforms not supporting SHM Bridge, the module should fall back to
> non-SHM mode. Isn't it the case?

Okay, I see. Amir clarified offline how the non-SHM mode works.
IIUC, the memory registration with QTEE is not required and instead QTEE
can directly work with memory references being passed as part of object
invocation.

So it looks like the user space app not working on db845c is another
issue with QTEE which needs to be fixed. 

-Sumit