linux-hardening - Re: [PATCH v3 05/12] dt-bindings: phy: renesas,usb2-phy: Add renesas,sysc-signals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb7e9828-a19d-4f45-b405-66aac85e3bcd@kernel.org>
Date: Thu, 22 May 2025 16:49:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Claudiu Beznea <claudiu.beznea@...on.dev>
Cc: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, geert+renesas@...der.be,
 magnus.damm@...il.com, yoshihiro.shimoda.uh@...esas.com, kees@...nel.org,
 gustavoars@...nel.org, biju.das.jz@...renesas.com,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-hardening@...r.kernel.org, john.madieu.xa@...renesas.com,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 05/12] dt-bindings: phy: renesas,usb2-phy: Add
 renesas,sysc-signals

On 22/05/2025 16:39, Claudiu Beznea wrote:
> 
> 
> On 22.05.2025 15:48, Krzysztof Kozlowski wrote:
>> On 22/05/2025 14:46, Krzysztof Kozlowski wrote:
>>>>>>  
>>>>>> +  - if:
>>>>>> +      properties:
>>>>>> +        compatible:
>>>>>> +          contains:
>>>>>> +            const: renesas,usb2-phy-r9a08g045
>>>>>> +    then:
>>>>>> +      required:
>>>>>> +        - renesas,sysc-signals
>>>>>
>>>>> That's ABI break.
>>>>
>>>> There is no in kernel device tree users of "renesas,usb2-phy-r9a08g045"
>>>> compatible. It is introduced in patch 11/12 from this series. With this do
>>>> you still consider it ABI break?
>>>
>>> Then this patch cannot be split from binding introducing the user. Don't
>>> add unused/undocumented compatibles.
>>>
>> Or you meant DTS?
> 
> Yes, I meant in tree DTS.

Rhetorical question (because we talked about this on mailing list many
times enough): what would be the point of any ABI if you can break it
and adjust in-tree DTS in the next patch?

Best regards,
Krzysztof