linux-hardening - Re: i915 utils: range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505301026.126AB6FFC@keescook>
Date: Fri, 30 May 2025 10:28:40 -0700
From: Kees Cook <kees@...nel.org>
To: Jani Nikula <jani.nikula@...el.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	linux-hardening@...r.kernel.org, intel-gfx@...ts.freedesktop.org
Subject: Re: i915 utils: range_overflows*()

On Fri, May 30, 2025 at 10:44:31AM +0300, Jani Nikula wrote:
> 
> Hi Kees -
> 
> drivers/gpu/drm/i915/i915_utils.h has a handful of helper macros for
> checking range overflows: range_overflows(), range_overflows_t(),
> range_overflows_end(), and range_overflows_end_t().
> 
> Looks like the first one has also been copy-pasted to
> include/drm/drm_buddy.h.
> 
> Feels like include/linux/overflow.h would be the right place for (some
> version of) them.
> 
> Thoughts?

Sure, yes! They need some documentation too. :) And probably some
renaming. It looks like range_overflows() is not end-inclusive, but
range_overflows_end() is? And the _t variants are forcing explicit
types (like max_t, but unlike struct_size_t).

-- 
Kees Cook