linux-hardening - Re: [PATCH] randstruct: gcc-plugin: Fix attribute addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87iklhjt5r.fsf@linaro.org>
Date: Sat, 31 May 2025 01:33:36 -0300
From: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
To: Kees Cook <kees@...nel.org>
Cc: Ingo Saitz <ingo@...nover.ccc.de>,  Nathan Chancellor
 <nathan@...nel.org>,  linux-hardening@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] randstruct: gcc-plugin: Fix attribute addition


Hello,

Kees Cook <kees@...nel.org> writes:

> Based on changes in the 2021 public version of the randstruct
> out-of-tree GCC plugin[1], more carefully update the attributes on
> resulting decls, to avoid tripping checks in GCC 15's
> comptypes_check_enum_int() when it has been configured with
> "--enable-checking=misc":
>
> arch/arm64/kernel/kexec_image.c:132:14: internal compiler error: in comptypes_check_enum_int, at c/c-typeck.cc:1519
>   132 | const struct kexec_file_ops kexec_image_ops = {
>       |              ^~~~~~~~~~~~~~
>  internal_error(char const*, ...), at gcc/gcc/diagnostic-global-context.cc:517
>  fancy_abort(char const*, int, char const*), at gcc/gcc/diagnostic.cc:1803
>  comptypes_check_enum_int(tree_node*, tree_node*, bool*), at gcc/gcc/c/c-typeck.cc:1519
>  ...

Great! Thank you.

> Link: https://archive.org/download/grsecurity/grsecurity-3.1-5.10.41-202105280954.patch.gz [1]
> Reported-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Closes: https://github.com/KSPP/linux/issues/367
> Closes: https://lore.kernel.org/lkml/20250530000646.104457-1-thiago.bauermann@linaro.org/
> Reported-by: Ingo Saitz <ingo@...nover.ccc.de>
> Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104745
> Fixes: 313dd1b62921 ("gcc-plugins: Add the randstruct plugin")
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Cc: Ingo Saitz <ingo@...nover.ccc.de>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: <linux-hardening@...r.kernel.org>
> ---
>  scripts/gcc-plugins/gcc-common.h              | 32 +++++++++++++++++++
>  scripts/gcc-plugins/randomize_layout_plugin.c | 22 ++++++-------
>  2 files changed, 43 insertions(+), 11 deletions(-)

Tested-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>

-- 
Thiago