linux-hardening - Re: [PATCH] ubsan: Fix incorrect hand-side used in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174888758557.4018560.13578751882908437370.b4-ty@kernel.org>
Date: Mon,  2 Jun 2025 11:06:27 -0700
From: Kees Cook <kees@...nel.org>
To: Junhui Pei <paradoxskin233@...il.com>
Cc: Kees Cook <kees@...nel.org>,
	elver@...gle.com,
	andreyknvl@...il.com,
	ryabinin.a.a@...il.com,
	akpm@...ux-foundation.org,
	kasan-dev@...glegroups.com,
	linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubsan: Fix incorrect hand-side used in handle

On Mon, 02 Jun 2025 23:38:41 +0800, Junhui Pei wrote:
> __ubsan_handle_divrem_overflow() incorrectly uses the RHS to report.
> It always reports the same log: division of -1 by -1. But it should
> report division of LHS by -1.

Oops, this has been wrong for a long time! :) I've added the appropriate
Fixes tag.

Applied to for-linus/hardening, thanks!

[1/1] ubsan: Fix incorrect hand-side used in handle
      https://git.kernel.org/kees/c/c50b612bef51

Take care,

-- 
Kees Cook