linux-hardening - Re: [PATCH v3][next] acpi: nfit: intel: avoid multiple -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <685c5d0062f2b_1608bd10051@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 25 Jun 2025 13:33:04 -0700
From: <dan.j.williams@...el.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Kees Cook
	<kees@...nel.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>
CC: Dan Williams <dan.j.williams@...el.com>, Vishal Verma
	<vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, Ira Weiny
	<ira.weiny@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
	<lenb@...nel.org>, <nvdimm@...ts.linux.dev>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v3][next] acpi: nfit: intel: avoid multiple
 -Wflex-array-member-not-at-end warnings

Gustavo A. R. Silva wrote:
[..]
> > I think it would be a pretty small and direct replacement:
> > 
> > 	TRAILING_OVERLAP(struct nd_cmd_pkg, pkg, nd_payload,
> > 			 struct nd_intel_get_security_state cmd;
> > 	) nd_cmd = {
> > 		...
> 
> Yes, this works. Hopefully, maintainers will comment on this and let us
> know what they prefer. :)

Hey Gustavo, apologies for the latency here. I think TRAILING_OVERLAP()
looks lovely for this if only because I can read that and have an idea
what it means vs wondering what this _offset_to_fam is about and needing
to read the comment.

If you can get me that patch on top of the TRAILING_OVERLAP() branch I
can test it out and ack it to let it do in through the KSPP tree.